feat: add drawable's fillColor, strokeColor option

daangn · Nov 7, 2024 · 301d2d2 · 301d2d2
1 parent 4c14fbd
commit 301d2d2
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 5 deletions.
diff --git a/packages/generator/CHANGELOG.md b/packages/generator/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @icona/generator
 
+## 0.9.1
+
+### Patch Changes
+
+- feat: add drawable's fillColor, strokeColor option
+- Updated dependencies
+  - @icona/types@0.9.1
+
 ## 0.9.0
 
 ### Minor Changes

diff --git a/packages/generator/package.json b/packages/generator/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@icona/generator",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/daangn/icona.git",
@@ -25,7 +25,7 @@
     "prepack": "yarn build"
   },
   "dependencies": {
-    "@icona/types": "^0.9.0",
+    "@icona/types": "^0.9.1",
     "@svgr/core": "^8.0.0",
     "@types/cli-progress": "^3.11.5",
     "cli-progress": "^3.12.0",

diff --git a/packages/generator/src/core/drawable.ts b/packages/generator/src/core/drawable.ts
@@ -26,6 +26,7 @@ export const generateDrawable = async (props: Props) => {
   const targetPath = getTargetPath(config.path || "drawable");
   const drawableConfig = config.svg2vectordrawableConfig || {};
   const defaultColor = config.defaultColor;
+  const fillColor = config.fillColor;
 
   if (!icons) {
     throw new Error("There is no icons data");
@@ -61,6 +62,19 @@ export const generateDrawable = async (props: Props) => {
       drawable = drawable.replace(/#FF212124/g, defaultColor);
     }
 
+    // NOTE(@junghyeonsu): android:fillColor="something" 인거를 ""사이에 있는 값을 변경하기
+    if (fillColor) {
+      drawable = drawable.replace(
+        /android:fillColor="[^"]*"/g,
+        `android:fillColor="${fillColor}"`,
+      );
+
+      drawable = drawable.replace(
+        /android:strokeColor="[^"]*"/g,
+        `android:strokeColor="${fillColor}"`,
+      );
+    }
+
     await writeFile(drawablePath, drawable);
     bar.increment();
   }

diff --git a/packages/types/CHANGELOG.md b/packages/types/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @icona/types
 
+## 0.9.1
+
+### Patch Changes
+
+- feat: add drawable's fillColor, strokeColor option
+
 ## 0.9.0
 
 ### Minor Changes

diff --git a/packages/types/package.json b/packages/types/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@icona/types",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/daangn/icona.git",

diff --git a/packages/types/src/lib.d.ts b/packages/types/src/lib.d.ts
@@ -125,8 +125,11 @@ export interface DrawableConfig extends BaseConfig {
    * drawable default color is #FF212124
    * if you want to change default color, you can use this option
    * @default #FF212124
+   * @deprecated
    */
   defaultColor?: string;
+
+  fillColor?: string;
 }
 
 export interface PNGConfig extends BaseConfig {}

diff --git a/test/icona.ts b/test/icona.ts
@@ -55,10 +55,11 @@ const pdfConfig: PDFConfig = {
 };
 
 const drawableConfig: DrawableConfig = {
-  active: false,
+  active: true,
   path: "drawable",
   svg2vectordrawableConfig: {},
-  defaultColor: "@color/gray900",
+  // defaultColor: "@color/gray900",
+  // fillColor: "@color/gray900",
 };
 
 const reactConfig: ReactConfig = {