Merge branch 'master' into feature/chunk

dachcom-digital · Feb 9, 2024 · d6408ef · d6408ef
2 parents 5521ae6 + 2e032ca
commit d6408ef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -2,6 +2,7 @@
 
 ## 5.0.4
 - Fix chunked upload `$type` and `$id` [@life-style-de](https://github.com/dachcom-digital/pimcore-formbuilder/pull/430)
+- Add Additional HrefTransformer validation for `$type` and `$id` [@patkul0](https://github.com/dachcom-digital/pimcore-formbuilder/pull/434)
 
 ## 5.0.3
 - Fix element type check in api channel [#423](https://github.com/dachcom-digital/pimcore-formbuilder/issues/423)

diff --git a/src/Transformer/HrefTransformer.php b/src/Transformer/HrefTransformer.php
@@ -28,8 +28,12 @@ public function reverseTransform(mixed $values, $optionConfig = null): array
             $type = $value['type'];
             $id = $value['id'];
 
+            if (empty($id) || !in_array($type, ['object', 'asset', 'document'])) {
+                continue;
+            }
+
             if (is_numeric($id)) {
-                $element = Service::getElementById($type, $id);
+                $element = Service::getElementById($type, (int) $id);
             } else {
                 // legacy
                 $element = Service::getElementByPath($type, $id);