Sourcery refactored master branch #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-10
to
+14
| from sage.all_cmdline import * | ||
| from sage.all_cmdline import * | ||
| import gmpy2 | ||
|
|
||
| # order is from secp256k1 curve it can be used any other. | ||
| order = int(0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141) | ||
| order = 115792089237316195423570985008687907852837564279074904382605163141518161494337 |
There was a problem hiding this comment.
Lines 10-14 refactored with the following changes:
- Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| if limit == None: | ||
| if limit is None: |
There was a problem hiding this comment.
Function load_csv refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
| @@ -76,7 +76,6 @@ def privkeys_from_reduced_matrix(msgs, sigs, pubs, matrix): | |||
| keys.append(key) | |||
| except Exception as e: | |||
| sys.stderr.write(str(e)+"\n") | |||
| pass | |||
There was a problem hiding this comment.
Function privkeys_from_reduced_matrix refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
Comment on lines
-101
to
+102
| keys = privkeys_from_reduced_matrix(msgs, sigs, pubs, new_matrix) | ||
| else: | ||
| new_matrix = matrix.BKZ(early_red=True, use_siegel=True) | ||
| keys = privkeys_from_reduced_matrix(msgs, sigs, pubs, new_matrix) | ||
|
|
||
| keys = privkeys_from_reduced_matrix(msgs, sigs, pubs, new_matrix) |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Comment on lines
-22
to
+27
| nonces = [fixed_bits + random.randrange(1, 2 ** bits) for i in range(n)] | ||
| nonces = [fixed_bits + random.randrange(1, 2 ** bits) for _ in range(n)] | ||
| else: | ||
| # generate n least significant bits, nonce must be less than order | ||
| nonces = [random.randrange(2 ** bits, order) + fixed_bits for i in range(n)] | ||
| nonces = [random.randrange(2 ** bits, order) + fixed_bits for _ in range(n)] | ||
|
|
||
| msgs = [random.randrange(1, order) for i in range(n)] | ||
| msgs = [random.randrange(1, order) for _ in range(n)] |
There was a problem hiding this comment.
Lines 22-27 refactored with the following changes:
- Replace unused for index with underscore [×3] (
for-index-underscore)
Comment on lines
-31
to
+32
| tmpstr = hex(i) | ||
| hexstr = tmpstr.replace('0x','').replace('L','').zfill(64) | ||
| return hexstr | ||
| tmpstr = hex(i) | ||
| return tmpstr.replace('0x','').replace('L','').zfill(64) |
There was a problem hiding this comment.
Function inttohex refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-36
to
+37
| print("%s,%s,%s,%s,%s" % ("1111",inttohex(sigs[i].r),inttohex(sigs[i].s),inttohex(msgs[i]),"0000")) | ||
| print( | ||
| f"1111,{inttohex(sigs[i].r)},{inttohex(sigs[i].s)},{inttohex(msgs[i])},0000" | ||
| ) |
There was a problem hiding this comment.
Lines 36-36 refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
sourcery-ai
bot
force-pushed
the
sourcery/master
branch
from
30b3549
to
47353a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!