Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): identifier mismatch & awkward English translations #509

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Integral-Tech
Copy link
Contributor

@Integral-Tech Integral-Tech commented Dec 28, 2024

Background

  • Some identifiers in en.json are inconsistent with zh-Hans.json.
  • Some English translations in en.json are awkward.

Checklist

Full Changelogs

  • Fix identifier mismatch between en.json and zh-Hans.json
  • Polish English translations

Issue Reference

Closes #[issue number]

Test Result

dae-prow[bot]
dae-prow bot previously approved these changes Dec 29, 2024
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@Integral-Tech Integral-Tech merged commit 1750dbe into daeuniverse:main Dec 29, 2024
11 of 13 checks passed
@Integral-Tech Integral-Tech deleted the fix-i18n-en branch December 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant