Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CanCall everywhere #5654

Draft
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

RustanLeino
Copy link
Collaborator

Description

This draft PR is working toward adding CanCall information everywhere.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

# Conflicts:
#	Source/Dafny/Verifier/Translator.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.TrStatement.cs
#	Source/IntegrationTests/TestFiles/LitTests/LitTest/dafny0/FunctionSpecifications.dfy
#	Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-370.dfy
#	Test/dafny0/FunctionSpecifications.dfy.expect
#	Test/git-issues/git-issue-370.dfy.expect
RustanLeino and others added 29 commits July 22, 2024 11:34
This helped many tests go through, including:
* autoRevealDependencies/subset-types.dfy
* git-issues/git-issue-1479.dfy
* git-issues/git-issue-362.dfy
# Conflicts:
#	Source/DafnyCore/Verifier/BoogieGenerator.ExpressionTranslator.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Fields.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Functions.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Iterators.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.LetExpr.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Methods.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.TrStatement.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.cs
# Conflicts:
#	Source/DafnyCore/Verifier/BoogieGenerator.ExpressionWellformed.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Functions.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Methods.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.TrStatement.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.Types.cs
#	Source/DafnyCore/Verifier/BoogieGenerator.cs
Test case that discovered problem: dafny0/MoForallCompilation.dfy
Without general traits, the new resolver infers the type of `fetch` to be `Ins?`, which causes a null dereference in `run()`.
Test case: git-issues/git-issue-405.dfy
@keyboardDrummer keyboardDrummer added the run-integration-tests Forces running the CI for integration tests even if the deep tests fail label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-integration-tests Forces running the CI for integration tests even if the deep tests fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants