Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the --extractTarget option into a command #5799

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Sep 30, 2024

Touchup PR for #5621

Description

  • Change the --extractTarget option into a hidden command
  • Make --help work when used on hidden commandds

How has this been tested?

  • Manually ran make extract in DafnyCore. This feature needs some tests but I'm leaving that out of scope of this PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat leaning toward making the command name or an argument more specific. What about either dafny extract-boogie file.bpl file.dfy or extract --language boogie file.bpl file.dfy with the latter case anticipating the potential for extraction to other languages, as well. What do the two of you think?

@keyboardDrummer
Copy link
Member Author

I'm somewhat leaning toward making the command name or an argument more specific. What about either dafny extract-boogie file.bpl file.dfy or extract --language boogie file.bpl file.dfy with the latter case anticipating the potential for extraction to other languages, as well. What do the two of you think?

It's a hidden command, so I think we're free to change the name/options later without having to be backwards compatible.

@atomb
Copy link
Member

atomb commented Sep 30, 2024

I'm somewhat leaning toward making the command name or an argument more specific. What about either dafny extract-boogie file.bpl file.dfy or extract --language boogie file.bpl file.dfy with the latter case anticipating the potential for extraction to other languages, as well. What do the two of you think?

It's a hidden command, so I think we're free to change the name/options later without having to be backwards compatible.

Good point. Given that, I'm happy with this.

@keyboardDrummer keyboardDrummer merged commit 0b44740 into dafny-lang:master Sep 30, 2024
22 checks passed
@keyboardDrummer keyboardDrummer deleted the touchup branch September 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants