Speed up dafny verify by reducing memory pressure
#5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…boardDrummer/dafny into onlyClaimVerificationMemoryPerModule
keyboardDrummer
requested review from
alex-chew
and removed request for
robin-aws
…boardDrummer/dafny into onlyClaimVerificationMemoryPerModule
alex-chew
previously approved these changes
Oct 16, 2024
robin-aws
requested changes
Oct 17, 2024
| new("--progress", "While verifying, output information that helps track progress") { | ||
| IsHidden = true | ||
| }; | ||
| public enum ProgressLevel { None, Symbol, SymbolParts } |
There was a problem hiding this comment.
Can the help text document the difference between the levels?
| @@ -40,5 +31,14 @@ Iterators.dfy(461,21): Error: this invariant could not be proved to be maintaine | |||
| Related message: loop invariant violation | |||
| Iterators.dfy(470,4): Error: possible violation of yield-ensures condition | |||
| Iterators.dfy(451,21): Related location: this proposition could not be proved | |||
| Iterators.dfy(251,9): Error: decreases clause might not decrease | |||
There was a problem hiding this comment.
Why did the ordering change? Seems like a regression since we've been better about keeping these in order lately.
There was a problem hiding this comment.
It's unavoidable, since we want to verify one module at a time to be able to release memory after verifying that module. When nested modules occur, the contents of different modules can be intertwined.
method A
module Nested {
method B
}
method CWe can do A,C,B or B,A,C, but we can no longer do A,B,C if we verify entire modules at a time.
…onMemoryPerModule
robin-aws
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dafny verifyHow has this been tested?
dafny verify, and confirmed that Boogie programs are no longer kept in memory after they've been verifiedBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.