Generalize JSON code to work with either --unicode-char mode
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-merge-unicode-char
davidcok
requested changes
Apr 12, 2023
More relevant to address in #51 - this one just builds on that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
src/JSON/Utils/Unicode.dfycode with references to theUnicodelibrary, not only because the latter has more correctness proofs but also because it more safely fails to translate invalid data rather than using replacement characters. This introduces more cases of needingResultwrappers, but most of the library needed them already anyway so it does not impact usability. I've also likely introduced some minor performance regressions compared to the current state ofjson-mergeby using the less-optimizedUnicodelibrary, but they should be worth it so this code can be merged, since performance can always be improved later.Adds a generic
UnicodeStringsmodule to help with this, which should be helpful for other codebases that need to support both modes. This also addresses #111.Open question: which of the two options in
UnicodeStrings.dfyshould we use in this repository in general?By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.