Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex escape update #1371

Merged
merged 1 commit into from
Mar 8, 2024
Merged

regex escape update #1371

merged 1 commit into from
Mar 8, 2024

Conversation

jbukhari
Copy link
Member

@jbukhari jbukhari commented Mar 5, 2024 •
edited
Loading

When checking if an auth heading is in use, the slash character ("/") needs to be escaped in the regex string. Regex is used by the auth heading search to ensure case sensitivity.

Closes #1357

@jbukhari jbukhari requested a review from aaronhelton March 5, 2024 18:02
@jbukhari jbukhari mentioned this pull request Mar 5, 2024
Closed
@aaronhelton aaronhelton requested a review from Yalshire2004 March 6, 2024 14:22
Yalshire2004
Yalshire2004 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Yalshire2004 Yalshire2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@aaronhelton aaronhelton merged commit 986c116 into master Mar 8, 2024
4 checks passed
@aaronhelton aaronhelton deleted the jb/1357 branch March 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronhelton aaronhelton aaronhelton approved these changes

@Yalshire2004 Yalshire2004 Yalshire2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot save authorities with " and /
3 participants
@jbukhari @aaronhelton @Yalshire2004