Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an export option for search results #1398

Merged
merged 27 commits into from
Aug 9, 2024
Merged

Conversation

aaronhelton
Copy link
Member

Closes #779

Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jbukhari and others added 3 commits April 17, 2024 13:41
* Re-apply URI encoding for browse URLs (#1326)

* Encode URI components in browse

* encode additional uri components in browse.js

* Add 596 to speeches search results (#1376)

* exploring issue

* add 596 to brief output

* Display 596 in speech results

Fixes #1361

* Display all 491 and 591 subfields in authority results (#1375)

Fixes #1344

* Add UI for uploading MARC records (#1377)

* start scaffolding upload

* start parsing

* basic functionality

* restructure

* continue building import

* get auth choices?

* auth lookup scaffold

* parse mrk for multiple records and complete POST; styling

* styling

* interactivity

* styling

* testing

* use different authExists function

* deactivate import UI for records that have fatal errors

* set workflow state and enable select all/none

* finish select options and tie into mass submit

* improve messaging and reinit

* add link to review

* move import link

* 1377 patch: implement auth validation at subfield level (#1378)

* implement auth validation at subfield level

* bugfix; error handling

---------

Co-authored-by: jbukhari <[email protected]>

---------

Co-authored-by: jbukhari <[email protected]>
Co-authored-by: jbukhari <[email protected]>

* MRK import optimization/UX (#1380)

* Employ concurrency in xref lookup/assign; add pending spinner while waiting for preview

* records detected spinner

* cleanup; update symbolInUse

---------

Co-authored-by: jbukhari <[email protected]>

* newline split (#1382)

Co-authored-by: jbukhari <[email protected]>
Co-authored-by: Aaron Helton <[email protected]>

* Bump werkzeug from 2.2.3 to 2.3.8 (#1386)

* Bump werkzeug from 2.2.3 to 2.3.8

Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.2.3 to 2.3.8.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.2.3...2.3.8)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* upgrade click, upgrade Flask, upgrade flask-wtf, upgrade lxml, upgrade PyYaml and replace flask-mongoengine (dead) with flask-mongoengine-3

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Helton <[email protected]>

* Basket optimizations (#1383)

* item lock db query optimization

* pass tests

* adding items to basket optimization

* move back to __init__for now

* regex char escape

---------

Co-authored-by: jbukhari <[email protected]>

* Browse index bugfix (#1390)

* update dlx

* update requirements for compatiblity

---------

Co-authored-by: J. Bukhari <[email protected]>

* update dlx (#1391)

Co-authored-by: J. Bukhari <[email protected]>

* remove unsafe use of locals() to pass route parameters (#1393)

Co-authored-by: J. Bukhari <[email protected]>

* revert lost changes (#1396)

Co-authored-by: J. Bukhari <[email protected]>

* Bump idna from 3.3 to 3.7 (#1394)

Bumps [idna](https://github.com/kjd/idna) from 3.3 to 3.7.
- [Release notes](https://github.com/kjd/idna/releases)
- [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
- [Commits](kjd/idna@v3.3...v3.7)

---
updated-dependencies:
- dependency-name: idna
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Aaron Helton <[email protected]>
Co-authored-by: jbukhari <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jbukhari jbukhari self-requested a review June 4, 2024 14:47
Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested #1439

* disable non functional inputs

* create download <a> tag inside template
@jbukhari jbukhari self-requested a review June 5, 2024 17:44
@aaronhelton
Copy link
Member Author

aaronhelton commented Jun 5, 2024

Next steps:

  1. Choose fields
  2. Include id field (001)
  3. Provide CSV option: Implement CSV serialization dlx#274
  4. Provide xrefs in MRK: Include xref in MRK serialization dlx#272

@aaronhelton
Copy link
Member Author

@jbukhari the CSV download works in the export modal now

dlx_rest/api/__init__.py Outdated Show resolved Hide resolved
@jbukhari jbukhari mentioned this pull request Jul 10, 2024
Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronhelton aaronhelton requested a review from jbukhari July 10, 2024 13:50
@jbukhari jbukhari mentioned this pull request Jul 12, 2024
Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jbukhari and others added 4 commits July 16, 2024 14:43
* Bump zipp from 3.8.0 to 3.19.1 (#1476)

Bumps [zipp](https://github.com/jaraco/zipp) from 3.8.0 to 3.19.1.
- [Release notes](https://github.com/jaraco/zipp/releases)
- [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst)
- [Commits](jaraco/zipp@v3.8.0...v3.19.1)

---
updated-dependencies:
- dependency-name: zipp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* NOT xref; $ regex search; CSV serialization (#1450)

* update dlx

* enable csv and tsv formatted records list api response

* update dlx and urllib3

* Enable subtype=all search and count (#1465)

* enable subtype=all search and count

* enable subtype=all from record editor and highlight all bibs collections (#1467)

* enable subtype=all from record editor and highlight all bibs collections

* Update count component to link to subtype=all searches for auths

---------

Co-authored-by: Aaron Helton <[email protected]>

* delete 999 on auth clone (#1468)

* Update python-tests.yml (#1473)

Run tests on PRs against all branches

* browse list bugfixes (#1475)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Helton <[email protected]>
Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jbukhari and others added 2 commits August 2, 2024 13:30
* Bump zipp from 3.8.0 to 3.19.1 (#1476)

Bumps [zipp](https://github.com/jaraco/zipp) from 3.8.0 to 3.19.1.
- [Release notes](https://github.com/jaraco/zipp/releases)
- [Changelog](https://github.com/jaraco/zipp/blob/main/NEWS.rst)
- [Commits](jaraco/zipp@v3.8.0...v3.19.1)

---
updated-dependencies:
- dependency-name: zipp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* NOT xref; $ regex search; CSV serialization (#1450)

* update dlx

* enable csv and tsv formatted records list api response

* update dlx and urllib3

* Enable subtype=all search and count (#1465)

* enable subtype=all search and count

* enable subtype=all from record editor and highlight all bibs collections (#1467)

* enable subtype=all from record editor and highlight all bibs collections

* Update count component to link to subtype=all searches for auths

---------

Co-authored-by: Aaron Helton <[email protected]>

* delete 999 on auth clone (#1468)

* Update python-tests.yml (#1473)

Run tests on PRs against all branches

* browse list bugfixes (#1475)

* Build auth cache on startup (#1480)

* build auth cache on startup

* Update dlx

* update dlx

* Update workflow triggers (#1481)

* Bump sentry-sdk from 1.25.1 to 2.8.0 (#1482)

Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.25.1 to 2.8.0.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@1.25.1...2.8.0)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* make a new read-only record view (#1483)

* make a new read-only record view

* add edit link and control fields

* downgrade Vue 2 because the latest release breaks advanced search (#1485)

* Bump version to 2.10.12 (#1494)

Fixes #1486

* Add subtype filtering to bibs search pages (#1497)

* build export file by paginating api

* adjust xml buffer

* spinner and layout tweaks

* reload window on modal close to cancel ongoing page fetching

* show api page traversal status

* xml node list syntax bugfix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Helton <[email protected]>
@jbukhari jbukhari self-requested a review August 6, 2024 16:15
Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export is not working when no "output fields" fields are specified by the user. Fix: #1504

Copy link
Member

@jbukhari jbukhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronhelton aaronhelton merged commit 2d3059f into main Aug 9, 2024
4 checks passed
@jbukhari jbukhari deleted the aaronhelton/issue779 branch September 10, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export search results as a spreadsheet option (similar to DL)
2 participants