Skip to content

Conversation

matipan
Copy link
Contributor

@matipan matipan commented Sep 25, 2025

Add a summary for all verbs that run commands. The summary includes the actual dagger command that was executed, a link to the trace and the output of dagger version. For example:

image

@matipan matipan changed the title Add summary for executable verbs Draft: Add summary for executable verbs Sep 25, 2025
@matipan matipan force-pushed the add-github-job-summary branch 9 times, most recently from 017e57d to 753904a Compare September 25, 2025 13:32
@matipan matipan requested review from jedevc and kpenfound and removed request for jedevc September 25, 2025 13:36
@matipan matipan changed the title Draft: Add summary for executable verbs Add summary for executable verbs Sep 25, 2025
@matipan matipan force-pushed the add-github-job-summary branch from 753904a to 39bd09d Compare September 25, 2025 13:37
Copy link
Member

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I'm just conflicted on whether we actually want this as the default.

e.g. if users want to generate their own job summaries, this is actually quite annoying.

Alternatively:

  • What if we had an input that was a file path to write the report to?
  • What if we had an output that was a file path / raw content of the report?
    Then we can control the format and magic generation of the report, while allowing user control over what actually happens to the report.

@matipan
Copy link
Contributor Author

matipan commented Sep 25, 2025

That's fair. I haven't really used summaries much. A quick search for a few examples seems like they usually have two options: one for specifying where to write the summary and another one to specify whether to automatically add it to GitHub actions. For example: https://github.com/marketplace/actions/super-linter#summary-outputs. I would do both options as well. So that its easy to automatically add summaries to github without more work than setting an option @jedevc

@matipan matipan force-pushed the add-github-job-summary branch 2 times, most recently from 55b8d12 to 358d712 Compare September 25, 2025 18:00
@matipan matipan requested a review from jedevc September 25, 2025 18:07
@matipan matipan force-pushed the add-github-job-summary branch from 358d712 to 78920e1 Compare September 26, 2025 19:29
@matipan matipan merged commit 27bae3a into dagger:main Sep 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants