Skip to content

Allow version without v #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Allow version without v #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39eb70c
add v to version if it does not have a leading v
kpenfound Sep 30, 2025
1a6d21e
test version without the v
kpenfound Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,24 @@ jobs:
exit 1
fi

- name: "Use 0.13.5 (no v)"
id: use-0-13-5
uses: ./
with:
version: 0.13.5
verb: core
args: version
- name: "Use 0.13.5 (check)"
run: |
target='${{ steps.use-0-13-5.outputs.output }}'
if [[ "$target" =~ v0\.13\.5 ]]; then
echo "matches"
exit 0
else
echo "does not match"
exit 1
fi

- name: "Use commit"
id: use-commit
uses: ./
Expand Down
3 changes: 3 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ runs:
VERSION=${{ inputs.version }}
if [[ "$VERSION" == "latest" ]]; then
VERSION=
elif [[ -n "$VERSION" && "$VERSION" != v* ]]; then
# Add 'v' prefix if version doesn't start with 'v' and is not empty
VERSION="v$VERSION"
fi
latest=$(curl https://dl.dagger.io/dagger/versions/latest)

Expand Down