Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): pass correct inputs from launch_job #143

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

vsayer
Copy link
Contributor

@vsayer vsayer commented Jun 21, 2023

  • The launch_job calling workflow needed to pass
    correctly-referenced inputs to the underlying run workflow.

- The launch_job calling workflow needed to pass
  correctly-referenced inputs to the underlying run workflow.
@gs-emp
Copy link
Contributor

gs-emp commented Jul 17, 2023

Ran into the same issue so - used the underlying job.

Copy link
Contributor

@gs-emp gs-emp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the issue

@vsayer
Copy link
Contributor Author

vsayer commented Aug 8, 2023

@gabestep-emp is this getting merged anytime soon?

@gs-emp
Copy link
Contributor

gs-emp commented Aug 9, 2023

Not sure I'm not a owner of the repo @prha @gibsondan can one of you approve and merge this pr?

@prha prha merged commit fcd9421 into dagster-io:main Aug 10, 2023
@vsayer vsayer deleted the patch-1 branch August 22, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants