Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for occasional ImportError: cannot import name 'Github' from 'github' (unknown location) #146

Merged
merged 9 commits into from
Jul 27, 2023

Conversation

shalabhc
Copy link
Contributor

Some users encounter this error which is fixed by doing import github before from github import ...

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Deploy failed Jun 27, 2023 at 06:36 PM (UTC)

@shalabhc shalabhc requested a review from prha June 27, 2023 18:34
@@ -1,4 +1,5 @@
import datetime
import github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand why this is even needed...

@shalabhc shalabhc requested a review from prha July 11, 2023 16:41
@shalabhc shalabhc merged commit 0ad44ef into main Jul 27, 2023
5 of 9 checks passed
@shalabhc shalabhc deleted the fix-github-import branch July 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants