Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add steps to build Python package with dbt project #147

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

rexledesma
Copy link
Contributor

@rexledesma rexledesma commented Jul 19, 2023

How I Tested These Changes

Run dbt NUX using these actions

@rexledesma
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Deploy failed Jul 28, 2023 at 09:23 PM (UTC)

@rexledesma rexledesma self-assigned this Jul 26, 2023
@rexledesma rexledesma changed the title chore: add dbt deps step chore: add steps to build python package with dbt project Jul 26, 2023
@rexledesma rexledesma changed the title chore: add steps to build python package with dbt project chore: add steps to build Python package with dbt project Jul 26, 2023
rexledesma added a commit to dagster-io/dagster that referenced this pull request Jul 27, 2023
## Summary & Motivation
Allow `dagster-dbt project scaffold` to load dbt projects from their
path in `package_data`. This will be invoked in the dbt NUX.

We hardcode `dbt-project` as the dbt project directory name for the
`package_data`. This restraint could be loosened in the future.

## How I Tested These Changes
- pytest
- dbt NUX creates a pull request that builds to branch deployment:
https://github.com/dagster-io/test-dagster-dbt-scaffold/pull/53
- Github actions that build a Dagster package utilizing `package_data`
dagster-io/dagster-cloud-action#147
benpankow pushed a commit to dagster-io/dagster that referenced this pull request Jul 27, 2023
## Summary & Motivation
Allow `dagster-dbt project scaffold` to load dbt projects from their
path in `package_data`. This will be invoked in the dbt NUX.

We hardcode `dbt-project` as the dbt project directory name for the
`package_data`. This restraint could be loosened in the future.

## How I Tested These Changes
- pytest
- dbt NUX creates a pull request that builds to branch deployment:
https://github.com/dagster-io/test-dagster-dbt-scaffold/pull/53
- Github actions that build a Dagster package utilizing `package_data`
dagster-io/dagster-cloud-action#147
@rexledesma rexledesma requested review from prha and shalabhc July 27, 2023 22:56
@rexledesma rexledesma force-pushed the rl/add-dbt-steps branch 3 times, most recently from 6bdce79 to d352bed Compare July 28, 2023 18:32
@rexledesma rexledesma force-pushed the rl/add-dbt-steps branch 2 times, most recently from a822125 to a13c88e Compare July 28, 2023 23:31
@rexledesma rexledesma merged commit 71049c6 into main Jul 28, 2023
9 of 18 checks passed
@rexledesma rexledesma deleted the rl/add-dbt-steps branch July 28, 2023 23:31
@rexledesma rexledesma restored the rl/add-dbt-steps branch July 29, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants