-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add steps to build Python package with dbt project #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Your pull request is automatically being deployed to Dagster Cloud.
|
rexledesma
force-pushed
the
rl/add-dbt-steps
branch
from
July 26, 2023 07:50
290c883
to
26c680e
Compare
rexledesma
changed the title
chore: add dbt deps step
chore: add steps to build python package with dbt project
Jul 26, 2023
rexledesma
changed the title
chore: add steps to build python package with dbt project
chore: add steps to build Python package with dbt project
Jul 26, 2023
rexledesma
force-pushed
the
rl/add-dbt-steps
branch
from
July 26, 2023 23:29
26c680e
to
7976bd3
Compare
rexledesma
added a commit
to dagster-io/dagster
that referenced
this pull request
Jul 27, 2023
## Summary & Motivation Allow `dagster-dbt project scaffold` to load dbt projects from their path in `package_data`. This will be invoked in the dbt NUX. We hardcode `dbt-project` as the dbt project directory name for the `package_data`. This restraint could be loosened in the future. ## How I Tested These Changes - pytest - dbt NUX creates a pull request that builds to branch deployment: https://github.com/dagster-io/test-dagster-dbt-scaffold/pull/53 - Github actions that build a Dagster package utilizing `package_data` dagster-io/dagster-cloud-action#147
benpankow
pushed a commit
to dagster-io/dagster
that referenced
this pull request
Jul 27, 2023
## Summary & Motivation Allow `dagster-dbt project scaffold` to load dbt projects from their path in `package_data`. This will be invoked in the dbt NUX. We hardcode `dbt-project` as the dbt project directory name for the `package_data`. This restraint could be loosened in the future. ## How I Tested These Changes - pytest - dbt NUX creates a pull request that builds to branch deployment: https://github.com/dagster-io/test-dagster-dbt-scaffold/pull/53 - Github actions that build a Dagster package utilizing `package_data` dagster-io/dagster-cloud-action#147
rexledesma
force-pushed
the
rl/add-dbt-steps
branch
3 times, most recently
from
July 28, 2023 18:32
6bdce79
to
d352bed
Compare
rexledesma
force-pushed
the
rl/add-dbt-steps
branch
from
July 28, 2023 18:50
d352bed
to
a13c88e
Compare
prha
approved these changes
Jul 28, 2023
rexledesma
force-pushed
the
rl/add-dbt-steps
branch
2 times, most recently
from
July 28, 2023 23:31
a822125
to
a13c88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I Tested These Changes
Run dbt NUX using these actions