Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DAGSTER_PYTHON_VERSION env for gitlab workflows #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DAGSTER_PYTHON_VERSION env for gitlab workflows #151

wants to merge 1 commit into from

Conversation

shalabhc
Copy link
Contributor

No description provided.

@shalabhc shalabhc requested a review from prha August 21, 2023 16:55
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Aug 21, 2023 at 04:58 PM (UTC)

@shalabhc
Copy link
Contributor Author

I tested this and found that it doesn't work. Specifically we get this error when trying to build for Python 3.10:

FileNotFoundError: [Errno 2] No such file or directory: 'python3.10'

This is because python3.10 is required in the docker env to build for 3.10. We only provide a python-3.8:slim Dockerfile. We'll may need to update the manylinux builder to also include the gitlab deploy.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prha prha prha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shalabhc @prha