[dbt nux] Allow specifying custom code location name #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
clairelin135
force-pushed
the
claire/edit-dagster-dbt-location-name
branch
from
4d8388f
to
94234f5
Compare
rexledesma
approved these changes
Aug 21, 2023
gitlab/dbt/serverless-ci-dbt.yml
Outdated
Comment on lines
6
to
7
| DBT_PROJECT_DIR: "${CI_PROJECT_DIR}" | ||
| DBT_PACKAGE_DATA_DIR: "${CI_PROJECT_DIR}/$DAGSTER_PROJECT_NAME/dbt-project" |
There was a problem hiding this comment.
We should prefix these as DAGSTER_DBT instead of just DBT while we're at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanies https://github.com/dagster-io/internal/pull/6520
The CI files expect the code location name to be
dagster_dbt_scaffold. We need to modify these references to accept a custom code location name.