Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly spell out that all paths will trigger branch deployment action #168

Closed
wants to merge 2 commits into from

Conversation

salazarm
Copy link

  1. Updating our actions to specify that all paths will trigger the action.
  2. Adding a filter step that helps avoid the issue described in this issue. TLDR: rebase commits end up re-triggering actions even if the PR being rebased didn't change the specified paths.

This should help our users not run into the same issue we ran into.

One thing that is not good about this approach is that the check_paths step runs no matter what. Ideally we could skip it in the default case of "**" (all paths) triggering the action.

Copy link

github-actions bot commented Apr 15, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud May 08, 2024 at 04:10 PM (UTC)

@rexledesma rexledesma removed their request for review April 29, 2024 19:41
@salazarm salazarm closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant