Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GITHUB_ACTION quotes in prerun step #176

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix GITHUB_ACTION quotes in prerun step #176

merged 1 commit into from
May 7, 2024

Conversation

shalabhc
Copy link
Contributor

@shalabhc shalabhc commented May 7, 2024

Without quotes this may error with "ambiguous redirect"

@shalabhc shalabhc requested a review from gibsondan May 7, 2024 17:07
Copy link

github-actions bot commented May 7, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud May 07, 2024 at 05:10 PM (UTC)

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that this is low risk but some test, either before or just after it is promoted, seems prudent

@shalabhc shalabhc merged commit 8827a95 into main May 7, 2024
7 of 9 checks passed
@shalabhc shalabhc deleted the prerun-hotfix branch May 7, 2024 17:14
shalabhc added a commit that referenced this pull request May 7, 2024
Without quotes this may error with "ambiguous redirect"
shalabhc added a commit that referenced this pull request May 9, 2024
* Rebuild 0.1.39

* Add branch options to create-rc

* Built from release-1.72

* Hotfix setup-python version

* Run pip in a separate step

* add shell

* Rebuilt from pypi

* Update CONTRIBUTION, add note for v0.1.27

* typos

* Add an Iterate step to the release docs

* Ignore warning lines in branch-deployment command output

* Fix GITHUB_ACTION quotes in prerun step (#176)

Without quotes this may error with "ambiguous redirect"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants