Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #177

Merged
merged 1 commit into from
May 9, 2024
Merged

Update CONTRIBUTING.md #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ __pycache__/
src/pex-builder/build

# locally built wheels for Dockerfile.dagster-manylinux-builder
wheels/*whl
wheels/*whl

# PyCharm IDE Config files
.idea/
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Steps to release

**Note**: These steps can also be used to release a docker-cloud-action image to test your changes.

## Step 1. Log into docker ghcr.io

See [authenticate to GHCR with a PAT](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry).
Expand Down Expand Up @@ -42,7 +44,7 @@ The point version is the next unused `v0.1.*` version, eg `v0.1.22` above. Creat

## Step 3. Build and deploy a new docker-cloud-action image, a new dagster.cloud.pex and update code references to docker

A script does this work:
A script does this work. **Note**: a virtual environment using Python3.8 is required to run the script.

```
# Note no 'v' prefix
Expand All @@ -51,7 +53,7 @@ A script does this work:

```

This leaves uncommited changes in the working directory.
This leaves uncommitted changes in the working directory.

# Commit and tag the new version

Expand Down
Loading