Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for dagster-cloud-action tests #183

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fixes for dagster-cloud-action tests #183

merged 2 commits into from
Jul 3, 2024

Conversation

gibsondan
Copy link
Member

Summary:

  • don't capture the output, that means we can't see what went wrong
  • don't fail if you can't remove the tempfile, just log
  • misc formatting

Summary:
- don't capture the output, that means we can't see what went wrong
- don't fail if you can't remove the tempfile, just log
- misc formatting
@gibsondan gibsondan requested review from shalabhc and prha July 1, 2024 18:25
Copy link

github-actions bot commented Jul 1, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Jul 02, 2024 at 05:45 PM (UTC)

@gibsondan gibsondan merged commit 301b494 into main Jul 3, 2024
7 of 9 checks passed
@gibsondan gibsondan deleted the fixactiontests branch July 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants