Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use docker manulinux based build for ubuntu-22.04 #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dont use docker manulinux based build for ubuntu-22.04 #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/deploy_pex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#!/usr/bin/env python

# Switches PEX deploy behavior based on github runner's ubuntu version
# - ubuntu-20.04 can always build pexes that work on our target platform
# - ubuntu-22.04 can only build pexes if there are no sdists (source only packages)
# - ubuntu-20.04 and ubuntu-20.04 can always build pexes that work on our target platform
# - ubuntu-24.04 can only build pexes if there are no sdists (source only packages)

# On ubuntu-20.04: forward args to `dagster-cloud --build-method=local`
# On ubuntu-22.04: forward args to `dagster-cloud --build-method=docker`
# - Sometimes 22.04 may try to build sdists but build the wrong version (since we are not yet
# On ubuntu-20.04 and ubuntu-20.04: forward args to `dagster-cloud --build-method=local`
# On ubuntu-24.04: forward args to `dagster-cloud --build-method=docker`
# - Sometimes 24.04 may try to build sdists but build the wrong version (since we are not yet
# using --complete-platform for pex). To avoid this situation, we always build dependencies in the
# right docker environment on 22.04. Note if dependencies are not being built, docker will not
# right docker environment on 24.04. Note if dependencies are not being built, docker will not
# be used. The source.pex is always built using the local environment.

import os
Expand Down Expand Up @@ -39,7 +39,7 @@ def main():

ubuntu_version = get_runner_ubuntu_version()
print("Running on Ubuntu", ubuntu_version, flush=True)
if ubuntu_version == "20.04":
if ubuntu_version == "20.04" or ubuntu_version == "22.04":
returncode, output = deploy_pex(args, deployment_name, build_method="local")
else:
returncode, output = deploy_pex(args, deployment_name, build_method="docker")
Expand Down
Loading