Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error message recommending to disable fast deploys in GitHub actions #198

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Sep 23, 2024

Fixes DS-190.

The message was confusing and misleading for some users.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Sep 23, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Sep 23, 2024 at 08:19 PM (UTC)

@maximearmstrong maximearmstrong self-assigned this Sep 23, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review September 23, 2024 21:13
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, strongly agree here. Thanks for fixing this.

@maximearmstrong maximearmstrong merged commit 468ba21 into main Sep 24, 2024
7 of 9 checks passed
@maximearmstrong maximearmstrong deleted the maxime/ds-190/remove-error-message-that-recomends-disabling-fast-deploys-in-github branch September 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants