-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-transitive sync status #22797
base: sean/non-transitive-default
Are you sure you want to change the base?
Non-transitive sync status #22797
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
ce5e7b4
to
fab4ff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could alternately leave the setting but start defaulting it to OFF instead of ON (so that if we need to we can re-enable it for specific orgs temporarily). Up to you.
fab4ff3
to
2f4ea09
Compare
On second thought I think this is a good idea because this could potentially change some sensor behavior ( |
2f4ea09
to
4b1e2f9
Compare
5db511f
to
6ab26d1
Compare
4b1e2f9
to
a739b4d
Compare
6ab26d1
to
80ca75e
Compare
a739b4d
to
8b27ec9
Compare
80ca75e
to
6ad59d9
Compare
8b27ec9
to
97ea475
Compare
6ad59d9
to
5bb3e40
Compare
97ea475
to
66f0adb
Compare
[INTERNAL_BRANCH=sean/non-transitive-sync]
5bb3e40
to
ddee405
Compare
66f0adb
to
b299e9c
Compare
Summary & Motivation
Internal companion PR: https://github.com/dagster-io/internal/pull/10427
Non-transitive sync status has been behind an org setting and was turned on for several pilot orgs a few months ago. We heard either positive reports on performance impact or nothing. This PR (and its companion) remove the org setting and turn on non-transitive unsynced for everyone.
How I Tested These Changes
Existing test suite.