-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic store connection APIs #28655
base: prha/partition_key_iterators
Are you sure you want to change the base?
Conversation
55fd1f1
to
b4220a7
Compare
4ab37c1
to
7e60a4b
Compare
b4220a7
to
1693ba5
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1693ba5
to
1efb8c0
Compare
7e60a4b
to
83ef046
Compare
d966792
to
072a617
Compare
9495729
to
cc79c5a
Compare
072a617
to
c28239b
Compare
cc79c5a
to
66fd0a5
Compare
c28239b
to
d4c3268
Compare
66fd0a5
to
fd87fca
Compare
bf5b5f5
to
c0e6838
Compare
c0e6838
to
d88c0a5
Compare
fd87fca
to
74595f5
Compare
d88c0a5
to
d81358c
Compare
74595f5
to
4d9c9df
Compare
return Connection.create_from_sequence( | ||
seq=partition_keys, limit=limit, ascending=ascending, cursor=cursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that Connection.create_from_sequence()
is being called, but this static method doesn't seem to be implemented in the Connection
class. A search through the codebase doesn't reveal any implementation of this method, which would cause a runtime AttributeError
when this code is executed.
This needs to be addressed by either:
- Implementing the
create_from_sequence()
method in theConnection
class, or - Modifying this code to use an existing method or directly construct the
Connection
object
Without this fix, the pagination functionality for dynamic partitions will fail when using cached partition keys.
GitHub Flavored Markdown
return Connection.create_from_sequence( | |
seq=partition_keys, limit=limit, ascending=ascending, cursor=cursor | |
return Connection.from_list( | |
items=partition_keys, limit=limit, ascending=ascending, cursor=cursor |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
d81358c
to
691d0a4
Compare
691d0a4
to
8194d38
Compare
8194d38
to
3479f85
Compare
15af281
to
4d30519
Compare
3479f85
to
60ace3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very exciting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note comment
60ace3b
to
3f91631
Compare
4d30519
to
bc0578f
Compare
3f91631
to
596cbbd
Compare
1cd8d9b
to
521c5cf
Compare
596cbbd
to
6713344
Compare
Summary & Motivation
Creates pagination connection API methods for fetching partition keys from the dynamic store (backed by the instance / event_log_storage).
How I Tested These Changes
BK