Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print -> context.log.debug to surface relevant logs #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redeux
Copy link

@redeux redeux commented Sep 1, 2023

Resolves #8

While making this I noticed that the print messages were originally context.log.info messages. I can see why info was not ideal. However, I still think it's important to have the option to surface these messages while running the project against a repository with more stargazers than can be captured in a single run. Otherwise, it's not entirely clear what's happening when execution is paused due to token depletion.

I think setting these logs to debug provides a good compromise. The logs don't clutter the UI by default, but the user still has the option to see them if desired.

I left print(f"User {user} not found.") in place because I couldn't think of a use case where that was an important log to surface during execution time.

I also corrected a minor typo that I found while reading the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simpler_model uncategorized log messages
1 participant