updated checks with latest API

dagster-io · Sep 14, 2023 · 2985d24 · 2985d24
1 parent 04cacb3
commit 2985d24
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/hooli_data_eng/assets/marketing/__init__.py b/hooli_data_eng/assets/marketing/__init__.py
@@ -22,8 +22,8 @@ def avg_orders(context: AssetExecutionContext, company_perf: pd.DataFrame) -> pd
     })
 
 @asset_check(
-        description="check that avg ordres are expected",
-        severity=AssetCheckSeverity.WARN,
+        description="check that avg orders are expected",
+        asset=avg_orders
 )
 def check_avg_orders(context, avg_orders: pd.DataFrame):
     avg = avg_orders['avg_order'][0]

diff --git a/hooli_data_eng/assets/raw_data/__init__.py b/hooli_data_eng/assets/raw_data/__init__.py
@@ -1,5 +1,5 @@
 import pandas as pd
-from dagster import asset, RetryPolicy, Backoff, Jitter, DailyPartitionsDefinition, OpExecutionContext, build_op_context, build_resources, asset_check, AssetCheckSeverity, AssetCheckResult
+from dagster import asset, RetryPolicy, Backoff, Jitter, DailyPartitionsDefinition, OpExecutionContext, build_op_context, build_resources, asset_check, AssetCheckSeverity, AssetCheckResult, AssetKey
 from datetime import datetime, timedelta
 from hooli_data_eng.resources.api import RawDataAPI
 
@@ -38,14 +38,16 @@ def users(context, api: RawDataAPI) -> pd.DataFrame:
     return pd.concat(all_users)
 
 @asset_check(
+        asset=AssetKey(["RAW_DATA", "users"]),
         description="check that users are from expected companies",
-        severity=AssetCheckSeverity.WARN,
+        #severity=AssetCheckSeverity.WARN,
 )
 def check_users(context, users: pd.DataFrame):
     unique_companies = pd.unique(users['company']).tolist()
     return AssetCheckResult(
         success=  (unique_companies == ["FoodCo", "ShopMart", "SportTime", "FamilyLtd"]),
-        metadata={"companies": unique_companies}
+        metadata={"companies": unique_companies},
+        severity=AssetCheckSeverity.WARN
     )
 
 @asset(