Merge pull request #119 from dagster-io/izzy/fix_hooli_basics

Fix hooli_basics bug

.github/workflows/deploy-dagster-cloud.yml

@@ -79,7 +79,7 @@ jobs:
         if: steps.prerun.outputs.result != 'skip'
         run: |
           pip install pip --upgrade;
-          pip install dagster-dbt dagster-cloud dbt-core dbt-duckdb dbt-snowflake --upgrade --upgrade-strategy eager;
+          pip install dagster-dbt dagster-cloud dbt-core dbt-duckdb dbt-snowflake grpcio-health-checking==1.64.3 --upgrade --upgrade-strategy eager;
           make deps
           dagster-dbt project prepare-and-package --file hooli_data_eng/project.py
           dagster-cloud ci dagster-dbt project manage-state --file hooli_data_eng/project.py --source-deployment data-eng-prod

.gitignore

@@ -174,3 +174,5 @@ tmp*/
 # dbt
 dbt_project/example.duckdb*
 dbt_project/logs
+
+.DS_Store

hooli_basics/definitions.py

@@ -19,15 +19,23 @@
 )
 def country_stats() -> DataFrame:
     df = read_html("https://tinyurl.com/mry64ebh", flavor='html5lib')[0]
-    df.columns = ["country", "continent", "region", "pop_2022", "pop_2023", "pop_change"]
+    df.columns = ["country", "Population (1 July 2022)", "Population (1 July 2023)", "Change", "UN Continental Region[1]", "UN Statistical Subregion[1]"]
+    df = df.drop(columns=["Change"])
+    df = df.rename(columns={
+        "UN Continental Region[1]": "continent",
+        "UN Statistical Subregion[1]": "region",
+        "Population (1 July 2022)": "pop_2022",
+        "Population (1 July 2023)": "pop_2023",
+        }
+    )
     df["pop_change"] = ((to_numeric(df["pop_2023"]) / to_numeric(df["pop_2022"])) - 1)*100
     return df
 
 @asset_check(
        asset=country_stats 
 )
 def check_country_stats(country_stats):
-    return AssetCheckResult(success=True)
+    return AssetCheckResult(passed=True)
 
 @asset(
     compute_kind="Kubernetes",

hooli_basics/requirements.txt

@@ -1,4 +1,5 @@
 pandas
+beautifulsoup4
 html5lib
 scikit-learn
 dagster

hooli_data_eng/assets/forecasting/__init__.py

@@ -5,14 +5,16 @@
 from scipy import optimize
 
 from dagster import (
-    AssetIn,
     asset,
+    AssetKey,
+    AssetIn,
     MonthlyPartitionsDefinition,
     Output,
     Field,
     Config,
     AssetExecutionContext,
     MaterializeResult,
+    SourceAsset,
 )
 from dagster_k8s import PipesK8sClient
 from dagstermill import define_dagstermill_asset
@@ -283,4 +285,4 @@ def k8s_pod_asset(
         namespace="data-eng-prod",
         base_pod_spec=pod_spec,
         extras=extras,
-    ).get_materialize_result()
+    ).get_materialize_result()