Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing compute and storage kind tags #106

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

izzye84
Copy link
Collaborator

@izzye84 izzye84 commented Jul 12, 2024

This PR does a couple things:

  • Defaults assets using the local file system as storage to an S3 storage_kind.
  • Renames config_utils.py to storage_kind_helpers.py to be more descriptive—determines storage kind based on environment

Worth noting, graph_assets don't currently support compute_kind—GitHub issue #14513

Copy link

github-actions bot commented Jul 12, 2024

Your pull request at commit 6f1ee2e2eae91e89d938849ec3e0cf7dd488bcf9 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Jul 12, 2024 at 10:11 PM (UTC)
batch_enrichment View in Cloud Jul 12, 2024 at 10:11 PM (UTC)
data-eng-pipeline View in Cloud Jul 12, 2024 at 10:11 PM (UTC)
snowflake_insights View in Cloud Jul 12, 2024 at 10:11 PM (UTC)
demo_assets View in Cloud Jul 12, 2024 at 10:11 PM (UTC)

Copy link
Contributor

@cnolanminich cnolanminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment but it's not critical

Copy link

github-actions bot commented Jul 16, 2024

Your pull request at commit fe791dac9921b799df6d028d45e7ec5baff10ada is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Jul 16, 2024 at 10:37 PM (UTC)
batch_enrichment View in Cloud Jul 16, 2024 at 10:37 PM (UTC)
data-eng-pipeline View in Cloud Jul 16, 2024 at 10:37 PM (UTC)
snowflake_insights View in Cloud Jul 16, 2024 at 10:37 PM (UTC)
demo_assets View in Cloud Jul 16, 2024 at 10:37 PM (UTC)

@izzye84 izzye84 merged commit 5e24870 into master Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants