Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #113

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update README.md #113

merged 2 commits into from
Aug 12, 2024

Conversation

slopp
Copy link
Collaborator

@slopp slopp commented Aug 8, 2024

updating readme mostly to test slim ci again

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Your pull request at commit 8ebe439288e2d461715b56dd5ceadbf2fb56a9d2 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Aug 08, 2024 at 11:05 PM (UTC)
batch_enrichment View in Cloud Aug 08, 2024 at 11:05 PM (UTC)
data-eng-pipeline View in Cloud Aug 08, 2024 at 11:05 PM (UTC)
demo_assets View in Cloud Aug 08, 2024 at 11:05 PM (UTC)
snowflake_insights View in Cloud Aug 08, 2024 at 11:05 PM (UTC)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Your pull request at commit 1aa8d7ce717e72773dbe79b30329705bfbbf5993 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Aug 12, 2024 at 09:03 PM (UTC)
batch_enrichment View in Cloud Aug 12, 2024 at 09:03 PM (UTC)
data-eng-pipeline View in Cloud Aug 12, 2024 at 09:03 PM (UTC)
demo_assets View in Cloud Aug 12, 2024 at 09:03 PM (UTC)
snowflake_insights View in Cloud Aug 12, 2024 at 09:03 PM (UTC)

cnolanminich
cnolanminich approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@cnolanminich cnolanminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! this is really helpful to have as a reference

cnolanminich
cnolanminich reviewed Aug 12, 2024
View reviewed changes
README.md

*Dev Notes in the Repo Wiki*
*Additional Dev Notes in the Repo Wiki*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any notes in the Wiki now? Or is this aspirational?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do! https://github.com/dagster-io/hooli-data-eng-pipelines/wiki/Development-Notes

(though they might be somewhat out of date)

@slopp
Update README.md
379da90 
updating readme mostly to test slim ci again
@slopp
Update README.md
d1768d9 
more details and re-trigger slim ci test
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Your pull request at commit d1768d9e356623a962aeae5d9aef36af7013d525 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Aug 12, 2024 at 10:54 PM (UTC)
batch_enrichment View in Cloud Aug 12, 2024 at 10:54 PM (UTC)
data-eng-pipeline View in Cloud Aug 12, 2024 at 10:54 PM (UTC)
demo_assets View in Cloud Aug 12, 2024 at 10:54 PM (UTC)
snowflake_insights View in Cloud Aug 12, 2024 at 10:54 PM (UTC)

@slopp slopp merged commit 09a8c30 into master Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnolanminich cnolanminich cnolanminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slopp @cnolanminich