Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed storage kind tags #126

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fixed storage kind tags #126

merged 4 commits into from
Sep 25, 2024

Conversation

izzye84
Copy link
Collaborator

@izzye84 izzye84 commented Sep 24, 2024

StorageKindTagSet was deprecated in favor of a more generic kind tag—build_kind_tag

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Your pull request at commit f836f142f49e7ce1f19bd7d51a71437fec98a5e1 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
snowflake_insights View in Cloud Sep 24, 2024 at 04:41 AM (UTC)
basics View in Cloud Sep 24, 2024 at 04:41 AM (UTC)
data-eng-pipeline View in Cloud Sep 24, 2024 at 04:41 AM (UTC)
demo_assets View in Cloud Sep 24, 2024 at 04:41 AM (UTC)
batch_enrichment View in Cloud Sep 24, 2024 at 04:41 AM (UTC)

@izzye84 izzye84 changed the title Fixed storage kind tags Fixed storage kind tags (WIP) Sep 24, 2024
slopp
slopp approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Your pull request at commit 913bfa93bb6a9b8cb957675043bc9e76969a07fc is automatically being deployed to Dagster Cloud.

Location Status Link Updated
snowflake_insights Deploy failed Sep 24, 2024 at 08:31 PM (UTC)
hooli_data_ingest Deploy failed Sep 24, 2024 at 08:31 PM (UTC)
basics Deploy failed Sep 24, 2024 at 08:31 PM (UTC)
data-eng-pipeline Deploy failed Sep 24, 2024 at 08:31 PM (UTC)
batch_enrichment Deploy failed Sep 24, 2024 at 08:31 PM (UTC)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Your pull request at commit ae23d3f673e4dcec8e4970beec321a6811abb641 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
snowflake_insights Deploy failed Sep 24, 2024 at 09:53 PM (UTC)
hooli_data_ingest Deploy failed Sep 24, 2024 at 09:53 PM (UTC)
basics Deploy failed Sep 24, 2024 at 09:53 PM (UTC)
data-eng-pipeline Deploy failed Sep 24, 2024 at 09:53 PM (UTC)
batch_enrichment Deploy failed Sep 24, 2024 at 09:53 PM (UTC)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Your pull request at commit 9f5e64b6b392a31b13dc63f7ee00c31e4485bc4d is automatically being deployed to Dagster Cloud.

Location Status Link Updated
hooli_data_ingest View in Cloud Sep 24, 2024 at 10:21 PM (UTC)
basics View in Cloud Sep 24, 2024 at 10:21 PM (UTC)
data-eng-pipeline View in Cloud Sep 24, 2024 at 10:21 PM (UTC)
snowflake_insights View in Cloud Sep 24, 2024 at 10:21 PM (UTC)
batch_enrichment View in Cloud Sep 24, 2024 at 10:21 PM (UTC)

@izzye84 izzye84 changed the title Fixed storage kind tags (WIP) Fixed storage kind tags Sep 24, 2024
@izzye84 izzye84 merged commit 7cafaba into master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopp slopp slopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izzye84 @slopp