Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset checks and project cleanup #41

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

izzye84
Copy link
Collaborator

@izzye84 izzye84 commented Sep 25, 2023

Organized assets, jobs, schedules, and sensors into their respective directories.

Also added a few asset checks as a new feature.

@izzye84 izzye84 requested a review from slopp September 25, 2023 22:51
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
data-eng-pipeline View in Cloud Sep 26, 2023 at 08:34 PM (UTC)
basics View in Cloud Sep 26, 2023 at 08:34 PM (UTC)

Copy link
Collaborator

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good to me, two things:

  1. I think we need to update the file relative paths for dbt stuff? Maybe?
  2. We mayneed to update the hooli_data_eng_tests to use the new location of things as well?

hooli_data_eng/resources/__init__.py Outdated Show resolved Hide resolved
@slopp slopp merged commit e4b252f into master Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants