Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add insights extra to dasgter-cloud #91

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

cnolanminich
Copy link
Contributor

adds dagster-cloud[insights] extra to all installs of dagster-cloud. We might only need it in hooli_snowflake_insights, and it's redundant for hooli_data_eng because it already has pyarrow from other dependencies

@cnolanminich cnolanminich requested a review from slopp May 15, 2024 17:42
Copy link

github-actions bot commented May 15, 2024

Your pull request at commit b5f63db00cea32597c679fc84a8aa5c54226c92b is automatically being deployed to Dagster Cloud.

Location Status Link Updated
demo_assets View in Cloud May 15, 2024 at 05:53 PM (UTC)
basics View in Cloud May 15, 2024 at 05:53 PM (UTC)
batch_enrichment View in Cloud May 15, 2024 at 05:53 PM (UTC)
data-eng-pipeline View in Cloud May 15, 2024 at 05:53 PM (UTC)
snowflake_insights View in Cloud May 15, 2024 at 05:53 PM (UTC)

Copy link
Collaborator

@slopp slopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this might have some redundancies, but I'm ok with it

thanks!

@cnolanminich cnolanminich merged commit b104476 into master May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants