Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new fetch row_count to dbt_assets #93

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

cnolanminich
Copy link
Contributor

@cnolanminich cnolanminich commented May 21, 2024

image

example in local (duckdb) 🎉

Oh what a beautiful thing (from branch deployment:

image

I also removed the dbt-core version pins in this PR, since more recent versions of dagster-dbt we support dbt 1.8.x

Copy link

github-actions bot commented May 21, 2024

Your pull request at commit 829329c09df14fa8b3cc0de657558f508a9ffa5e is automatically being deployed to Dagster Cloud.

Location Status Link Updated
demo_assets View in Cloud May 21, 2024 at 03:04 PM (UTC)
basics View in Cloud May 21, 2024 at 03:04 PM (UTC)
batch_enrichment View in Cloud May 21, 2024 at 03:04 PM (UTC)
data-eng-pipeline View in Cloud May 21, 2024 at 03:04 PM (UTC)
snowflake_insights View in Cloud May 21, 2024 at 03:04 PM (UTC)

@cnolanminich
Copy link
Contributor Author

Will need to wait for dagster-io/dagster#21952 to be merged and released

Copy link

github-actions bot commented May 22, 2024

Your pull request at commit 0df1abb8f3462494702e0f3b9fea4df8ce7a536e is automatically being deployed to Dagster Cloud.

Location Status Link Updated
demo_assets View in Cloud May 22, 2024 at 07:47 PM (UTC)
basics View in Cloud May 22, 2024 at 07:47 PM (UTC)
batch_enrichment View in Cloud May 22, 2024 at 07:47 PM (UTC)
data-eng-pipeline View in Cloud May 22, 2024 at 07:47 PM (UTC)
snowflake_insights View in Cloud May 22, 2024 at 07:47 PM (UTC)

Copy link

github-actions bot commented May 22, 2024

Your pull request at commit 14d75afef4ebf66611ca147ab1053a7dfb434b8b is automatically being deployed to Dagster Cloud.

Location Status Link Updated
demo_assets View in Cloud May 24, 2024 at 02:09 PM (UTC)
basics View in Cloud May 24, 2024 at 02:09 PM (UTC)
batch_enrichment View in Cloud May 24, 2024 at 02:09 PM (UTC)
data-eng-pipeline View in Cloud May 24, 2024 at 02:09 PM (UTC)
snowflake_insights View in Cloud May 24, 2024 at 02:09 PM (UTC)

@izzye84
Copy link
Collaborator

izzye84 commented May 24, 2024

LGTM

@cnolanminich cnolanminich merged commit de18252 into master May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants