You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding storage_kind to non-dbt assets in the hooli_data_eng code location.
Summary of changes:
Added config_utils.py to dynamically generate storage_kind (duckdb or snowflake) based on deployment (local or branch/prod)
Added storage_kind to non-dbt assets where the compute_kind didn't make this obvious
One thing to note, I defaulted the storage_kind to S3 for assets using the model_io_manager since it uses the FilesystemIOManager() locally and S3 in branch and prod deployments.
One question -- is the goal of this PR that all of these assets (see below) have storage kinds? Also, I noticed that Sling doesn't -- I'm guessing that is a change to our sling integration and not something we can implement on our side though
One question -- is the goal of this PR that all of these assets (see below) have storage kinds? Also, I noticed that Sling doesn't -- I'm guessing that is a change to our sling integration and not something we can implement on our side though
I updated all assets (with a couple exceptions) to include storage_kind since the compute_kind doesn't necessarily have to match the storage_kind. That said, dagstermill_assets (model_nb) aren't yet supported and I'm still unsure how we want to represent the k8s storage_kind.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
storage_kindto non-dbt assets in thehooli_data_engcode location.Summary of changes:
config_utils.pyto dynamically generate storage_kind (duckdb or snowflake) based on deployment (local or branch/prod)compute_kinddidn't make this obviousOne thing to note, I defaulted the storage_kind to S3 for assets using the
model_io_managersince it uses theFilesystemIOManager()locally and S3 in branch and prod deployments.