Merge tag '0.4.3'

LogTape 0.4.3

CHANGES.md

@@ -16,6 +16,17 @@ To be released.
 [#8]: https://github.com/dahlia/logtape/pull/8
 
 
+Version 0.4.3
+-------------
+
+Released on August 22, 2024.
+
+ -  Fixed a bug where `getRotatingFileSink()` function had failed to create
+    a new log file when there's no log file to rotate yet.  [[#9]]
+
+[#9]: https://github.com/dahlia/logtape/issues/9
+
+
 Version 0.4.2
 -------------
 

deno.json

@@ -7,6 +7,7 @@
     "@std/assert": "jsr:@std/assert@^0.222.1",
     "@std/async": "jsr:@std/async@^0.222.1",
     "@std/fs": "jsr:@std/fs@^0.223.0",
+    "@std/path": "jsr:@std/path@^1.0.2",
     "@std/testing": "jsr:@std/testing@^0.222.1",
     "consolemock": "npm:consolemock@^1.1.0",
     "which_runtime": "https://deno.land/x/[email protected]/mod.ts"

logtape/config.ts

@@ -181,6 +181,7 @@ export async function configure<
   }
 
   if ("process" in globalThis) { // @ts-ignore: It's fine to use process in Node
+    // deno-lint-ignore no-node-globals
     process.on("exit", dispose);
   } else { // @ts-ignore: It's fine to addEventListener() on the browser/Deno
     addEventListener("unload", dispose);

logtape/filesink.test.ts

@@ -1,4 +1,5 @@
 import { assertEquals } from "@std/assert/assert-equals";
+import { join } from "@std/path/join";
 import { getFileSink, getRotatingFileSink } from "./filesink.deno.ts";
 import { debug, error, fatal, info, warning } from "./fixtures.ts";
 import type { Sink } from "./sink.ts";
@@ -89,6 +90,18 @@ Deno.test("getRotatingFileSink()", () => {
 2023-11-14 22:13:20.000 +00:00 [INF] my-app·junk: Hello, 123 & 456!
 `,
   );
+
+  const dirPath = Deno.makeTempDirSync();
+  const path2 = join(dirPath, "log");
+  const sink2: Sink & Disposable = getRotatingFileSink(path2, {
+    maxSize: 150,
+  });
+  sink2(debug);
+  assertEquals(
+    Deno.readTextFileSync(path2),
+    "2023-11-14 22:13:20.000 +00:00 [DBG] my-app·junk: Hello, 123 & 456!\n",
+  );
+  sink2[Symbol.dispose]();
 });
 
 // cSpell: ignore filesink

logtape/sink.ts

@@ -249,7 +249,13 @@ export function getRotatingFileSink<TFile>(
   const encoder = options.encoder ?? new TextEncoder();
   const maxSize = options.maxSize ?? 1024 * 1024;
   const maxFiles = options.maxFiles ?? 5;
-  let { size: offset } = options.statSync(path);
+  let offset: number = 0;
+  try {
+    const stat = options.statSync(path);
+    offset = stat.size;
+  } catch {
+    // Continue as the offset is already 0.
+  }
   let fd = options.openSync(path);
   function shouldRollover(bytes: Uint8Array): boolean {
     return offset + bytes.length > maxSize;