Merge remote-tracking branch 'upstream/main' into refactor/create-api

dai-shi · Jan 13, 2025 · 29f34d4 · 29f34d4
2 parents cca3b8f + 42f9000
commit 29f34d4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -91,6 +91,7 @@ jobs:
       - run: pnpm exec playwright test --shard=${{ matrix.shared }}/${{ matrix.shardTotal }}
         env:
           TEMP_DIR: ${{ runner.temp }}
+          VITE_EXPERIMENTAL_WAKU_ROUTER: true
       - uses: actions/upload-artifact@v4
         if: always()
         with:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -27,3 +27,5 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install
       - run: pnpm test
+        env:
+          VITE_EXPERIMENTAL_WAKU_ROUTER: true
diff --git a/packages/waku/src/router/create-pages.ts b/packages/waku/src/router/create-pages.ts
@@ -409,6 +409,10 @@ export const createPages = <
   };
 
   const createApi: CreateApi = (options) => {
+    if (!import.meta.env.VITE_EXPERIMENTAL_WAKU_ROUTER) {
+      console.warn('createApi is still experimental');
+      return;
+    }
     if (configured) {
       throw new Error('createApi no longer available');
     }