Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run e2e tests with canary versions on manual comment of /canary-ci run #1047

Closed
wants to merge 5 commits into from

Conversation

tylersayshi
Copy link
Contributor

@tylersayshi tylersayshi commented Dec 9, 2024

Update react versions to canary when running /canary-ci run

This will change before marking the PR ready to be something we only do on main
I just want to see if this works on its own first
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 9, 2024 11:19pm

Copy link

codesandbox-ci bot commented Dec 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tylersayshi tylersayshi changed the title test: update react before installing for CI tests ci: run e2e tests with canary versions on main Dec 9, 2024
@tylersayshi
Copy link
Contributor Author

@dai-shi is it ok to always use only canary versions when running the e2e tests on main or do we need to re-run with the versions we use in PRs as well?

Currently this just updates all to canary when on main, but I am open to reconsidering

@dai-shi
Copy link
Owner

dai-shi commented Dec 9, 2024

Yeah, that's concerning.
On second thought, can we trigger the CI on canary manually in a PR?
It can be a separate workflow besides ci.yaml.
Something like this: https://github.com/pmndrs/jotai/blob/d2a42f785b9803764b97fbb0ccd349d2d99069e9/.github/workflows/ecosystem-ci.yml#L10

and this: https://docs.github.com/en/actions/sharing-automations/reusing-workflows#calling-a-reusable-workflow

@tylersayshi
Copy link
Contributor Author

/canary-ci run

@tylersayshi
Copy link
Contributor Author

/canary-ci run

@dai-shi is this how this is supposed to work? I think I am missing something for how the jotai ecosystem ci is supposed to work, but I think I mirrored the changes here for it to work the same?

@tylersayshi tylersayshi marked this pull request as ready for review December 9, 2024 08:00
@tylersayshi tylersayshi changed the title ci: run e2e tests with canary versions on main ci: run e2e tests with canary versions on manual comment of /canary-ci run Dec 9, 2024
@dai-shi
Copy link
Owner

dai-shi commented Dec 9, 2024

is this how this is supposed to work?

I tried it in jotai before, but it had to be merged into main.

@tylersayshi
Copy link
Contributor Author

closing in favor of #1057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants