-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run e2e tests with canary versions on manual comment of /canary-ci run #1047
Conversation
This will change before marking the PR ready to be something we only do on main I just want to see if this works on its own first
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@dai-shi is it ok to always use only canary versions when running the e2e tests on main or do we need to re-run with the versions we use in PRs as well? Currently this just updates all to canary when on main, but I am open to reconsidering |
Yeah, that's concerning. and this: https://docs.github.com/en/actions/sharing-automations/reusing-workflows#calling-a-reusable-workflow |
/canary-ci run |
@dai-shi is this how this is supposed to work? I think I am missing something for how the jotai ecosystem ci is supposed to work, but I think I mirrored the changes here for it to work the same? |
I tried it in |
closing in favor of #1057 |
Update react versions to canary when running
/canary-ci run