Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check calls to _hide() in more places #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check calls to _hide() in more places #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/matching_market.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ contract MatchingMarket is MatchingEvents, ExpiringMarket, DSNote {
require(!isOfferSorted(id)); //make sure offers[id] is not yet sorted
require(isActive(id)); //make sure offers[id] is active

_hide(id); //remove offer from unsorted offers list
require(_hide(id)); //remove offer from unsorted offers list
_sort(id, pos); //put offer into the sorted offers list
LogInsert(msg.sender, id);
return true;
Expand Down Expand Up @@ -399,7 +399,7 @@ contract MatchingMarket is MatchingEvents, ExpiringMarket, DSNote {
//offers[id] must be removed from sorted list because all of it is bought
_unsort(id);
}else{
_hide(id);
require(_hide(id));
}
}
require(super.buy(id, amount));
Expand Down