Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shared post unreadable on tablet #4130

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix: shared post unreadable on tablet #4130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56eecbc
fix: shared post unreadable on tablet
AmarTrebinjac Jan 30, 2025
42d605a
Merge branch 'main' into WT-2251
AmarTrebinjac Jan 30, 2025
dfc6154
Merge branch 'main' into WT-2251
AmarTrebinjac Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions packages/shared/src/components/post/SharePostContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ReactElement } from 'react';
import React, { useContext } from 'react';
import classNames from 'classnames';
import PostSourceInfo from './PostSourceInfo';
import { ReadArticleButton } from '../cards/common/ReadArticleButton';
import type { Post, SharedPost } from '../../graphql/posts';
Expand All @@ -8,7 +9,9 @@ import {
isInternalReadType,
isSharedPostSquadPost,
} from '../../graphql/posts';
import SettingsContext from '../../contexts/SettingsContext';
import SettingsContext, {
useSettingsContext,
} from '../../contexts/SettingsContext';
import { combinedClicks } from '../../lib/click';
import { SharedLinkContainer } from './common/SharedLinkContainer';
import { SharedPostLink } from './common/SharedPostLink';
Expand Down Expand Up @@ -53,6 +56,7 @@ export function CommonSharePostContent({
source,
onReadArticle,
}: CommonSharePostContentProps): ReactElement {
const { sidebarExpanded } = useSettingsContext();
const { openNewTab } = useContext(SettingsContext);
const openArticle = (e: React.MouseEvent) => {
e.stopPropagation();
Expand Down Expand Up @@ -88,8 +92,18 @@ export function CommonSharePostContent({

return (
<SharedLinkContainer summary={sharedPost.summary} className="mb-5 mt-8">
<div className="flex max-w-full flex-col p-4 pt-5 laptop:flex-row">
<div className="mb-5 flex max-w-full flex-1 flex-col truncate laptop:mb-0">
<div
className={classNames(
'flex max-w-full flex-col gap-2 p-4 pt-5',
sidebarExpanded ? 'laptopL:flex-row' : 'laptop:flex-row',
)}
>
<div
className={classNames(
'mb-5 flex max-w-full flex-1 flex-col truncate',
sidebarExpanded ? 'laptopL:mb-0' : 'laptop:mb-0',
)}
>
<SharedPostLink
source={source}
sharedPost={sharedPost}
Expand Down Expand Up @@ -127,7 +141,7 @@ export function CommonSharePostContent({
source={source}
sharedPost={sharedPost}
onGoToLinkProps={combinedClicks(openArticle)}
className="ml-2 block h-fit w-70 cursor-pointer overflow-hidden rounded-16"
className="mx-auto block h-fit w-70 cursor-pointer overflow-hidden rounded-16"
>
<LazyImage
imgSrc={sharedPost.image}
Expand Down