feat(gathering): message copyier #5013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshanzel
requested review from
AmarTrebinjac,
capJavert,
ilasw,
nensidosari,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
omBratteng
approved these changes
Oct 23, 2025
rebelchris
approved these changes
Oct 27, 2025
Contributor
rebelchris
left a comment
rebelchris
left a comment
There was a problem hiding this comment.
Fingers crossed it does't affect chrome review
omBratteng
reviewed
Oct 28, 2025
packages/extension/src/companion/suggestion/MessageSuggestion.tsx
Outdated
Show resolved
Hide resolved
omBratteng
reviewed
Oct 28, 2025
omBratteng
reviewed
Oct 28, 2025
packages/extension/src/companion/suggestion/MessageSuggestionPopup.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ole-Martin Bratteng <[email protected]>
omBratteng
reviewed
Oct 29, 2025
| const [popups, setPopups] = useState<MessagePopup[]>([]); | ||
| const [observer] = useState( | ||
| new MutationObserver(async () => { | ||
| await new Promise((resolve) => setTimeout(resolve, 10)); // wait for the dom to update |
Member
There was a problem hiding this comment.
extract this into a util we can re-use. could name it sleep.
export const sleep = (time: number) => new Promise((resolve) => setTimeout(resolve, time))
omBratteng
reviewed
Oct 29, 2025
Comment on lines
+20
to
+22
| const toUpdate = []; | ||
|
|
||
| bubbles.forEach((bubble) => { |
Member
There was a problem hiding this comment.
does bubbles.map work? Then we can just do const toUpdate = bubbles.map.....
Contributor
Author
There was a problem hiding this comment.
Yeah that can work. Will just have to add .filter for ids that are not found. The additional iteration shouldn't impace the performance that much.
omBratteng
approved these changes
Oct 29, 2025
Member
omBratteng
left a comment
omBratteng
left a comment
There was a problem hiding this comment.
LGTM, haven't tested it yet though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-message-copyier.preview.app.daily.dev