-
Notifications
You must be signed in to change notification settings - Fork 279
feat: list user experiences #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@sshanzel it would be nice to have any story in storybook for experiences, it would make testing easier when we have no user experiences at the moment. |
rebelchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
| title: string; | ||
| } | ||
|
|
||
| const groupListByCompany = <T extends UserExperience>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need it on FE, doesn't the BE already structure this somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna leave for now, but reminder to myself to check later down the line
packages/shared/src/features/profile/components/experience/ProfileUserExperiences.tsx
Outdated
Show resolved
Hide resolved
…-1027-experiences # Conflicts: # packages/webapp/pages/[userId]/index.tsx
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-1027
Preview domain
https://mi-1027-experiences.preview.app.daily.dev