Skip to content

Conversation

@sshanzel
Copy link
Contributor

@sshanzel sshanzel commented Oct 27, 2025

Changes

  • Unified User Experience component. The design team agreed to keep them consistent across the board.
  • This also introduces the query to fetch user experiences.
  • Actions such as clicking options/edit, are going to be raised in another PR.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Jira ticket

MI-1027

Preview domain

https://mi-1027-experiences.preview.app.daily.dev

@sshanzel sshanzel requested a review from a team as a code owner October 27, 2025 13:39
@sshanzel sshanzel requested review from AmarTrebinjac, capJavert, ilasw, nensidosari, omBratteng and rebelchris and removed request for a team October 27, 2025 13:39
@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
daily-webapp Ready Ready Preview Nov 4, 2025 0:48am
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
storybook Ignored Ignored Nov 4, 2025 0:48am

@sshanzel sshanzel marked this pull request as draft October 27, 2025 13:40
@nensidosari
Copy link
Contributor

@sshanzel it would be nice to have any story in storybook for experiences, it would make testing easier when we have no user experiences at the moment.

Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

title: string;
}

const groupListByCompany = <T extends UserExperience>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it on FE, doesn't the BE already structure this somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna leave for now, but reminder to myself to check later down the line

@rebelchris rebelchris merged commit e6f606b into MI-1027-profile Nov 4, 2025
5 of 7 checks passed
@rebelchris rebelchris deleted the MI-1027-experiences branch November 4, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants