feat: new activity section + fix profile betwen laptop tablet transition #5028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Base automatically changed from
MI-1069-about-section-profile
to
MI-1027-profile
October 31, 2025 09:53
nensidosari
commented
Nov 4, 2025
There was a problem hiding this comment.
We've always had trouble in profile in between laptop/tablet breakpoints (closing the sidebar at this certain breakpoint gives us more room for the profile - which seems like a nice trade off.)
Comment on lines
24
to
36
| useEffect(() => { | ||
| const mediaQuery = window.matchMedia(`(max-width: ${COLLAPSE_BREAKPOINT - 1}px)`); | ||
|
|
||
| const handleBreakpointChange = (e: MediaQueryListEvent) => { | ||
| if (e.matches && sidebarExpandedRef.current) { | ||
| toggleSidebarExpanded(); | ||
| } | ||
| }; | ||
|
|
||
| mediaQuery.addEventListener('change', handleBreakpointChange); | ||
| return () => mediaQuery.removeEventListener('change', handleBreakpointChange); | ||
| }, [toggleSidebarExpanded]); | ||
| }; |
There was a problem hiding this comment.
Best approach to do this as it only fires in breakpoint crossings
…-1071-activity-section-profile # Conflicts: # packages/shared/src/components/HorizontalScroll/HorizontalScrollHeader.tsx # packages/webapp/pages/[userId]/index.tsx
rebelchris
requested review from
capJavert,
ilasw,
omBratteng,
rebelchris and
sshanzel
and removed request for
a team
rebelchris
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-1071
Preview domain
https://mi-1071-activity-section-profile.preview.app.daily.dev