-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Source post moderation entity and queries #2388
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good overall, just few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments on the ID, but requires @capJavert opinion I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great work 🎉
After some discussions with @ilasw and @sshanzel we decided to split the Source Post Moderation and the Query into its own PR again. Coupling it with the creation of posts was a mistake on my part and has held up some tasks unnecessarily long.
So this is a split of Squad post moderation flow, taking out the entity, migration and the query into their own PR to get it reviewed and approved faster.