Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Source post moderation entity and queries #2388

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AmarTrebinjac
Copy link
Contributor

After some discussions with @ilasw and @sshanzel we decided to split the Source Post Moderation and the Query into its own PR again. Coupling it with the creation of posts was a mistake on my part and has held up some tasks unnecessarily long.

So this is a split of Squad post moderation flow, taking out the entity, migration and the query into their own PR to get it reviewed and approved faster.

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review November 5, 2024 00:29
@AmarTrebinjac AmarTrebinjac requested review from capJavert and a team as code owners November 5, 2024 00:29
Copy link
Contributor

@ilasw ilasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good overall, just few questions

src/entity/SourcePostModeration.ts Outdated Show resolved Hide resolved
src/entity/SourcePostModeration.ts Show resolved Hide resolved
src/entity/SourcePostModeration.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Outdated Show resolved Hide resolved
__tests__/fixture/source.ts Show resolved Hide resolved
__tests__/posts.ts Show resolved Hide resolved
src/entity/SourcePostModeration.ts Outdated Show resolved Hide resolved
src/entity/SourcePostModeration.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Show resolved Hide resolved
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments on the ID, but requires @capJavert opinion I think.

src/entity/SourcePostModeration.ts Outdated Show resolved Hide resolved
src/migration/1730799822114-SourcePostModeration.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ilasw ilasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants