Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

添加了动画过渡效果 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

添加了动画过渡效果 #47

wants to merge 1 commit into from

Conversation

zhangruize
Copy link

Add animation between every setProgress.

@zhangruize
添加了动画过渡效果
7a666a9 
Add animation between every setProgress.
@daimajia
Copy link
Owner

daimajia commented Oct 3, 2017 •
edited
Loading

Hi @zhangruize ,
It's really a marvelous feature for this tiny library!

There are some suggestions on the code part, hope you can do some update.

  • add a comment on the ANIMATION_DURATION varaible, and it's better to allow developers to modify the animation_duration
  • allow developers to customize the Interpolator
  • allow developers to enable or disable this feature.

Really thanks for your contribution on this project. 🌹 Looking forward to your update on this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangruize @daimajia