Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to set custom value instead of percentage #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

possible to set custom value instead of percentage #6

wants to merge 1 commit into from

Conversation

Devofure
Copy link

If you want, you could do the same changes instead of making a pull, I hope it is ok with you about the changes I made

@daimajia
Copy link
Owner

Hi, could you describe when we need this method?

setCustomValue will also make the incrementProgressBy invalid, right?

@Devofure
Copy link
Author

well the reason I made setCustomValue is because I wanted to show for example:
this are 3 progressbar: ***** 5 files""""" , ******** 8 files"" , ********** 10 files

I want to put another value instead of percentage, the progress could work as before but the value of the progress could be another, like how many files already have been downloaded in numbers.

So the incrementProgressBy doesn't have to be invalid.

You could implement this idea in you project, I think it will be a great feature.

@costimuraru
Copy link

👍

Copy link

@hippyk hippyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we give the ProgressBar two parameters. One is the current percentage for calculating the length of the reached part. The other is the current custom value to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants