-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pay: intent status #1362
pay: intent status #1362
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
export enum DaimoPayOrderStatusSource { | ||
WAITING_PAYMENT = "waiting_payment", | ||
PENDING_PROCESSING = "pending_processing", | ||
PROCESSED = "processed", | ||
START_SUBMITTED = "start_submitted", | ||
START_SUCCESSFUL = "processed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend keeping same names, confusing if different in codebase vs db
however, we can add docstring, eg
/** Start transaction confirmed. Bridge initiated, if applicable. */
PROCESSED = "processed",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of https://github.com/daimo-eth/daimo-internal/pull/137/files#