Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pay: intent status #1362

Merged
merged 5 commits into from
Oct 24, 2024
Merged

pay: intent status #1362

merged 5 commits into from
Oct 24, 2024

Conversation

dcposch
Copy link
Member

@dcposch dcposch commented Oct 22, 2024

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daimo-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:21am
daimo-web-stage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:21am

Copy link

socket-security bot commented Oct 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +32 8.52 MB nicolo-ribaudo
npm/@coinbase/[email protected] None 0 126 kB coinbase-owner
npm/@expo/[email protected] filesystem Transitive: environment, unsafe +16 1.55 MB brentvatne
npm/@expo/[email protected] environment, filesystem +14 498 kB tsapeta
npm/@expo/[email protected] None 0 5.76 MB evanbacon
npm/@gorhom/[email protected] None +1 1.43 MB gorhom
npm/@headlessui/[email protected] environment +2 814 kB malfaitrobin
npm/@neynar/[email protected] Transitive: environment, filesystem, network, shell +8 4.25 MB shreyaschorge
npm/@noble/[email protected] None +1 2.44 MB paulmillr
npm/@rainbow-me/[email protected] environment, network +5 3.47 MB danielsinclair
npm/@react-navigation/[email protected] Transitive: environment +1 453 kB satya164
npm/@react-navigation/[email protected] Transitive: environment +1 474 kB satya164
npm/@react-navigation/[email protected] environment +2 1.34 MB satya164
npm/@react-navigation/[email protected] Transitive: environment +1 899 kB satya164
npm/@sentry/[email protected] None +7 81.4 MB benvinegar, billyvg, evanpurkhiser, ...8 more
npm/@slack/[email protected] network Transitive: filesystem +27 5.66 MB e-zim
npm/@tanstack/[email protected] None +1 1.19 MB nksaraf, tannerlinsley
npm/@trpc/[email protected] None 0 358 kB katt
npm/@types/[email protected] None 0 78.8 kB types
npm/@types/[email protected] None 0 868 kB types
npm/@types/[email protected] None +1 2.28 MB types
npm/@types/[email protected] None 0 0 B
npm/@types/[email protected] None +1 445 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/@types/[email protected] None +2 2.28 MB types
npm/@vercel/[email protected] environment, filesystem, network +1 7.64 MB vercel-release-bot
npm/@wagmi/[email protected] Transitive: environment, filesystem, network, shell +45 224 MB awkweb

🚮 Removed packages: npm/@babel/[email protected], npm/@expo/[email protected], npm/@expo/[email protected], npm/@expo/[email protected], npm/@gorhom/[email protected], npm/@headlessui/[email protected], npm/@neynar/[email protected], npm/@rainbow-me/[email protected], npm/@react-navigation/[email protected], npm/@react-navigation/[email protected], npm/@react-navigation/[email protected], npm/@react-navigation/[email protected], npm/@sentry/[email protected], npm/@slack/[email protected], npm/@tanstack/[email protected], npm/@trpc/[email protected]+e9899d002, npm/@trpc/[email protected]+e9899d002, npm/@trpc/[email protected]+e9899d002, npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

export enum DaimoPayOrderStatusSource {
WAITING_PAYMENT = "waiting_payment",
PENDING_PROCESSING = "pending_processing",
PROCESSED = "processed",
START_SUBMITTED = "start_submitted",
START_SUCCESSFUL = "processed",
Copy link
Member Author

@dcposch dcposch Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend keeping same names, confusing if different in codebase vs db

however, we can add docstring, eg

  /** Start transaction confirmed. Bridge initiated, if applicable. */
  PROCESSED = "processed",

Copy link
Member Author

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants