Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-01: add security contact #47

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ env:
jobs:
test:
runs-on: ubuntu-latest
env:
FOUNDRY_GAS_LIMIT: 10000000000
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -23,11 +25,11 @@ jobs:

- run: |
forge --version
forge build --sizes
forge build --via-ir --sizes
id: build

- run: |
forge test -vv
forge test --via-ir -vv
forge coverage --ir-minimum --report lcov
git diff --exit-code
id: test
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Our implementation was inspired by [Renaud Dubois/Ledger's FCL library](https://
Available on any chain. If missing, see `deploy.sh`.

Install with:

- `forge install daimo-eth/p256-verifier`
- add `p256-verifier/=lib/p256-verifier/src/` to remappings.txt

Expand All @@ -33,7 +34,7 @@ uint256 x, y; // public key
bool valid = P256.verifySignature(hash, r, s, x, y);
```

Alternately, calling `P256.verifySignatureAllowMalleability` ignores
Alternately, calling `P256.verifySignatureAllowMalleability` ignores
malleability of signatures, matching the behavior specified by the NIST standard
exactly.

Expand All @@ -51,7 +52,7 @@ Run `foundryup` to ensure you have the latest foundry. Then,
```
git clone --recurse-submodules [email protected]:daimo-eth/p256-verifier
cd p256-verifier
forge test -vv
forge test --via-ir -vv
```

This runs test input and output handling as well as all applicable Wycheproof
Expand Down Expand Up @@ -87,7 +88,7 @@ npm test
# Validate that all vectors also work with EIP-7212
# Test the fallback contract...
cd ..
forge test -vv
forge test --via-ir -vv

# In future, execution spec and clients can test against the same clean vectors
```
Expand Down
Loading
Loading