Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update #27

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Dependency update #27

merged 1 commit into from
Oct 13, 2024

Conversation

daksh7011
Copy link
Owner

@daksh7011 daksh7011 commented Oct 13, 2024

Description

  • Update deps
  • Improve usage of extension for elvis equality check

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Dependency update

How Has This Been Tested?

Automation and by running the project

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Summary by Sourcery

Update Kotlin plugin versions to 2.0.21 and enhance the isBot function with improved elvis equality check.

New Features:

  • Improve the usage of the extension for elvis equality check in the isBot function.

Enhancements:

  • Update Kotlin plugin versions from 2.0.20 to 2.0.21 in the project configuration files.

- Improve usage of extension for elvis equality check
Copy link

sourcery-ai bot commented Oct 13, 2024

Reviewer's Guide by Sourcery

This pull request updates dependencies and improves the usage of an extension function for checking bot status. The changes are minor but important for maintaining the project's up-to-date status and improving code clarity.

Class diagram for updated extension function

classDiagram
    class Message {
        - Boolean isBot
        + Boolean isBot()
        + Boolean isNotBot()
        + Boolean containsF()
        + Boolean containsNigga()
    }
    note for Message "Updated isBot() method to improve elvis equality check"
Loading

File-Level Changes

Change Details Files
Update Kotlin version from 2.0.20 to 2.0.21
  • Update Kotlin JVM plugin version to 2.0.21
  • Update Kotlin Serialization plugin version to 2.0.21
  • Update Kotlin version in libs.versions.toml to 2.0.21
settings.gradle.kts
gradle/libs.versions.toml
Improve bot status check in Message extension function
  • Change isBot() function implementation from 'author?.isBot ?: true' to 'author?.isBot != false'
src/main/kotlin/troy/utils/Extensions.kt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daksh7011 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@daksh7011 daksh7011 enabled auto-merge October 13, 2024 19:35
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@daksh7011 daksh7011 merged commit 550d58e into develop Oct 13, 2024
5 checks passed
@daksh7011 daksh7011 deleted the chore/deps-update branch October 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant