fix serde / no_std incompatibility #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 20, 2023
|
@ryan-mob the CI is now in main - wanna rebase to that and remove |
…lize` and `Deserialize` implementations to use a custom visitor, removing the need for `alloc` or `std` for embedded use, and making this consistent with implementations in [curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek/blob/a63e14f4ded078d6bf262ba0b3f47026bdd7f7c0/src/edwards.rs#L269). @pinkforest seems like it'd be good to have some serde tests / this should go over dalek-cryptography#289? Co-Authored-By: Vlad Semenov <[email protected]>
ryankurte
force-pushed
the
fix/serde-std
branch
from
71c6d62 to
863f1dc
Compare
tarcieri
approved these changes
Mar 21, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates serde
SerializeandDeserializeimplementations to use a custom visitor, allowingserdeto be used withoutallocorstdfor embedded, and making this consistent with implementations in curve25519-dalek.as an alternative #288 (thanks @semenov-vladyslav)
@pinkforest seems like it'd be good to have some serde tests / this should go over #289?